feat: add xunit3 to benchmarks

[thomhurst]

Fixes #2624

[claude]

Claude finished @thomhurst's task —— View job

---

PR Review: Adding xunit3 to Benchmarks

I've completed my review of this PR that adds xUnit v3 support to the benchmarks. Here's my comprehensive feedback:

✅ Overall Assessment

This is a well-implemented addition that properly extends the existing benchmark infrastructure to include xUnit v3. The implementation follows consistent patterns and maintains the existing code quality.

Code Quality & Best Practices

Excellent:

• ✅ Consistent with existing patterns - the xUnit3 implementation follows the exact same conditional compilation pattern as other frameworks
• ✅ Modern C# syntax used throughout (collection expressions, proper async patterns)
• ✅ No code duplication - reuses existing test logic with framework-specific attributes
• ✅ Clean separation of concerns with conditional compilation directives

Package Management:

• ✅ Proper package versioning in Directory.Packages.props (xunit.v3 3.1.0, extensibility.core 3.1.0, assert 3.1.0)
• ✅ Centralized package management maintained
• ✅ Appropriate package references in project file conditional on TestFramework=XUNIT3

Performance Considerations

Strong Performance Focus:

• ✅ Adds xUnit v3 to both build and runtime benchmarks (BuildBenchmarks.cs:49-57, RuntimeBenchmarks.cs:71-80)
• ✅ Uses same CLI arguments pattern for consistent benchmarking: ["test", dllPath, "--filter", $"FullyQualifiedName~{ClassName}"]
• ✅ Proper output stream handling for benchmark measurement
• ✅ No performance regressions introduced - this is purely additive

Security Considerations

No Security Concerns:

• ✅ No external dependencies beyond official Microsoft/xUnit packages
• ✅ No dynamic code execution or reflection beyond normal test framework usage
• ✅ Uses standard .NET test SDK patterns

Test Coverage & Implementation

Comprehensive Coverage:

• ✅ All existing test categories covered: BasicTests, AsyncTests, DataDrivenTests, FixtureTests, ParallelTests, RepeatTests, SetupTeardownTests, AssertionTests
• ✅ Identical test logic across all frameworks using conditional compilation (#if XUNIT3)
• ✅ Proper attribute mapping: [Fact] for simple tests, [Theory] for parameterized tests
• ✅ Correct assertion syntax: Assert.Equal(), Assert.True(), etc.

Framework Integration:

• ✅ Added to GlobalUsings.cs:5-6 with proper namespace import
• ✅ Project configuration handles executable output type correctly (OutputType Condition="'$(TestFramework)' == 'XUNIT3'">Exe</OutputType>)
• ✅ Benchmark documentation updated appropriately (BENCHMARKS.md:3)

Potential Issues

None Found:

• ✅ No bugs or logical errors detected
• ✅ All conditional compilation paths properly closed
• ✅ Framework detection logic is sound
• ✅ No missing dependencies or version conflicts

Recommendations

Minor Enhancement Opportunities:

1. Consider adding xUnit v3-specific configuration options if they become available (though not necessary for initial implementation)
2. Future: Monitor xUnit v3 feature evolution for potential benchmark-specific optimizations

Compliance with TUnit Guidelines

Fully Compliant:

• ✅ Performance-first approach maintained
• ✅ No breaking changes to existing APIs
• ✅ Modern C# syntax used consistently
• ✅ Thread-safe implementation (inherits from existing patterns)
• ✅ No snapshot test changes required (this is benchmark code, not core TUnit)

Summary

This PR successfully adds xUnit v3 to the benchmark suite with:

• ✅ High code quality - follows existing patterns perfectly
• ✅ No bugs - implementation is solid and consistent
• ✅ Good performance design - proper benchmark integration
• ✅ No security issues - uses standard packages and patterns
• ✅ Complete test coverage - all test categories included

Recommendation: ✅ APPROVE - This is a clean, well-implemented addition that enhances the benchmark suite without introducing any risks or issues.

[claude]

Claude finished @thomhurst's task —— View job

---

PR Review: Adding xUnit v3 to Benchmarks

I've completed a comprehensive review of this PR that adds xUnit v3 support to the TUnit benchmark suite. Here's my detailed feedback:

Todo List:

• Read and understand the changed files
• Analyze code quality and best practices
• Check for potential bugs or issues
• Evaluate performance considerations
• Review security concerns
• Assess test coverage
• Provide comprehensive feedback

---

✅ Overall Assessment

This is a well-implemented addition that properly extends the existing benchmark infrastructure to include xUnit v3. The implementation follows consistent patterns and maintains the existing code quality standards.

Code Quality & Best Practices

Excellent Implementation:

• ✅ Consistent conditional compilation: The xUnit3 implementation follows the exact same pattern as other frameworks (#elif XUNIT3)
• ✅ Modern C# syntax: Uses collection expressions, proper async patterns, and follows TUnit guidelines
• ✅ No code duplication: Reuses existing test logic with framework-specific attributes and assertions
• ✅ Clean separation of concerns: Well-organized conditional compilation directives

Package Management:

• ✅ Proper package versioning in Directory.Packages.props:92-94 (xunit.v3 3.1.0, xunit.v3.assert 3.1.0, xunit.v3.extensibility.core 3.1.0)
• ✅ Centralized package management maintained
• ✅ Appropriate conditional package references in UnifiedTests.csproj:51-58

Performance Considerations

Strong Performance Focus:

• ✅ Build benchmarks: Added Build_xUnit3() method in BuildBenchmarks.cs:49-57 with consistent CLI arguments
• ✅ Runtime benchmarks: Added xUnit3() method in RuntimeBenchmarks.cs:71-80 with proper output stream handling
• ✅ Consistent execution pattern: Uses same filter arguments as other frameworks: ["test", dllPath, "--filter", $"FullyQualifiedName~{ClassName}"]
• ✅ No performance regressions: This is purely additive functionality

Security Considerations

No Security Concerns:

• ✅ No external dependencies beyond official Microsoft/xUnit packages
• ✅ No dynamic code execution or reflection beyond normal test framework usage
• ✅ Uses standard .NET test SDK patterns
• ✅ Package sources are from official NuGet packages

Test Coverage & Implementation

Comprehensive Coverage:

• ✅ All test categories covered: BasicTests, AsyncTests, DataDrivenTests, FixtureTests, ParallelTests, RepeatTests, SetupTeardownTests, AssertionTests
• ✅ Identical test logic: Proper use of #elif XUNIT3 conditional compilation across all test files
• ✅ Correct attribute mapping:
  • [Fact] for simple tests (BasicTests.cs:16, AssertionTests.cs:16)
  • [Theory] for parameterized tests (DataDrivenTests.cs:21)
  • [InlineData] for inline test data (DataDrivenTests.cs:22-25)
  • [MemberData] for complex data sources (DataDrivenTests.cs:109)
• ✅ Proper assertion syntax: Uses xUnit v3 assertion methods (Assert.Equal(), Assert.True(), etc.)

Framework Integration:

• ✅ Added to GlobalUsings.cs:5-6 with proper conditional namespace import
• ✅ Project configuration handles executable output type correctly (UnifiedTests.csproj:14)
• ✅ Custom output paths configured properly (UnifiedTests.csproj:20-25)
• ✅ Benchmark documentation updated (BENCHMARKS.md:3,53)

Compliance with TUnit Guidelines

Fully Compliant:

• ✅ Performance-first approach: Maintains benchmark focus without impacting core framework
• ✅ No breaking changes: This is additive functionality only
• ✅ Modern C# syntax: Consistent with project style guidelines
• ✅ Thread-safe implementation: Inherits thread safety from existing benchmark patterns
• ✅ No snapshot tests affected: This is benchmark code, not core TUnit functionality

Potential Issues

None Found:

• ✅ No bugs or logical errors detected
• ✅ All conditional compilation paths properly closed
• ✅ Framework detection logic is sound
• ✅ No missing dependencies or version conflicts
• ✅ Package versions are stable and current (3.1.0)

Minor Observations

Implementation Notes:

• The xUnit v3 implementation correctly shares the same assertion syntax as xUnit v2 (XUNIT || XUNIT3) since v3 maintains API compatibility
• Output paths and compilation constants are properly configured for the XUNIT3 framework
• Benchmark methodology remains consistent across all frameworks

Summary

This PR successfully adds xUnit v3 to the benchmark suite with:

• ✅ High code quality - follows existing patterns perfectly
• ✅ No bugs or issues - implementation is solid and consistent
• ✅ Excellent performance design - proper benchmark integration
• ✅ No security concerns - uses standard packages and patterns
• ✅ Complete test coverage - all test categories included
• ✅ Full TUnit compliance - adheres to all project guidelines

Recommendation: ✅ APPROVE - This is a clean, well-implemented addition that enhances the benchmark suite's coverage of test frameworks without introducing any risks or issues.

---