Fix generic DependsOn<T> attribute not working

[Copilot]

Generic DependsOn<T> was ignoring the type parameter T, treating [DependsOn<ClassA>("MethodName")] as [DependsOn("MethodName")] (same-class dependency).

Root cause: The source generator only examined constructor arguments. For generic attributes, T is a type argument on the attribute class, not a constructor argument.

Fix: Extract type from attributeData.AttributeClass.TypeArguments[0] when attribute is generic.

Changes

• TestMetadataGenerator.GenerateTestDependency() - Check for generic DependsOnAttribute<T> and extract type argument for all three constructor overloads:

  • DependsOn<T>() - all tests in class T
  • DependsOn<T>(methodName) - specific test in class T
  • DependsOn<T>(methodName, parameterTypes) - specific overload in class T

• GenericDependsOnTests.cs - Integration tests for both DependsOn<T>() and DependsOn<T>(methodName) patterns

Example

// Before: ClassB.A runs immediately (bug - dependency ignored)
// After: ClassB.A waits for ClassA.A to complete
public class ClassB
{
    [Test, DependsOn<ClassA>(nameof(ClassA.A))]
    public async Task A() { ... }
}

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[Bug]: Generic DependsOn not working</issue_title>
<issue_description>### Description

The generic version of DependsOnAttribute does not work correctly, an example is included in the reproduction steps

Expected Behavior

All tests in the reproduction steps should pass

Actual Behavior

ClassB.A fails

Steps to Reproduce

Run the following test suite:

public static class Deps
{
    public static int GenericDep = 1;
    public static int TypeofDep = 1;
}

public class ClassA
{
    [Test]
    public async Task A()
    {
        await Assert.That(Deps.GenericDep).IsEqualTo(1);
        Deps.GenericDep = 2;
    }

    [Test]
    public async Task B()
    {
        await Assert.That(Deps.TypeofDep).IsEqualTo(1);
        Deps.TypeofDep = 2;
    }
}

public class ClassB
{
    [Test, DependsOn<ClassA>(nameof(ClassA.A))]
    public async Task A()
    {
        await Assert.That(Deps.GenericDep).IsEqualTo(2);
    }

    [Test, DependsOn(typeof(ClassA), nameof(ClassA.B))]
    public async Task B()
    {
        await Assert.That(Deps.TypeofDep).IsEqualTo(2);
    }
}

TUnit Version

1.9.2

.NET Version

.NET 10.0

Operating System

Windows

IDE / Test Runner

dotnet CLI (dotnet test / dotnet run)

Error Output / Stack Trace

Expected to be 2
but found 1

at Assert.That(Deps.GenericDep).IsEqualTo(2)
   at TUnit.Assertions.Core.Assertion`1.ExecuteCoreAsync()
   at TUnit.Assertions.Core.Assertion`1.AssertAsync()
   at TUnitExperiments.Sql.Tests.ClassB.A() in D:\Repositories\TUnitExperiments\TUnitExperiments.Sql.Tests\ProductTests.cs:line 51
   at TUnit.Core.TestMetadata`1.<>c__DisplayClass13_0.<<get_CreateExecutableTestFactory>b__2>d.MoveNext()
--- End of stack trace from previous location ---
   at TUnit.Core.ExecutableTest.InvokeTestAsync(Object instance, CancellationToken cancellationToken)
   at TUnit.Engine.TestExecutor.ExecuteTestAsync(AbstractExecutableTest executableTest, CancellationToken cancellationToken)
   at TUnit.Engine.TestExecutor.ExecuteAsync(AbstractExecutableTest executableTest, TestInitializer testInitializer, CancellationToken cancellationToken)
   at TUnit.Engine.TestExecutor.ExecuteAsync(AbstractExecutableTest executableTest, TestInitializer testInitializer, CancellationToken cancellationToken)
   at TUnit.Engine.Services.TestExecution.TestCoordinator.<>c__DisplayClass12_0.<<ExecuteTestInternalAsync>b__1>d.MoveNext()
--- End of stack trace from previous location ---
   at TUnit.Engine.Services.TestExecution.TestCoordinator.<>c__DisplayClass12_0.<<ExecuteTestInternalAsync>b__1>d.MoveNext()
--- End of stack trace from previous location ---
   at TUnit.Engine.Helpers.TimeoutHelper.<>c__DisplayClass1_0.<<ExecuteWithTimeoutAsync>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at TUnit.Engine.Helpers.TimeoutHelper.ExecuteWithTimeoutAsync[T](Func`2 taskFactory, Nullable`1 timeout, CancellationToken cancellationToken, String timeoutMessage)
   at TUnit.Engine.Helpers.TimeoutHelper.ExecuteWithTimeoutAsync(Func`2 taskFactory, Nullable`1 timeout, CancellationToken cancellationToken, String timeoutMessage)
   at TUnit.Engine.Services.TestExecution.TestCoordinator.<>c__DisplayClass12_0.<<ExecuteTestInternalAsync>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at TUnit.Engine.Services.TestExecution.RetryHelper.ExecuteWithRetry(TestContext testContext, Func`1 action)
   at TUnit.Engine.Services.TestExecution.RetryHelper.ExecuteWithRetry(TestContext testContext, Func`1 action)
   at TUnit.Engine.Services.TestExecution.TestCoordinator.ExecuteTestInternalAsync(AbstractExecutableTest test, CancellationToken cancellationToken)

Additional Context

No response

IDE-Specific Issue?

• I've confirmed this issue occurs when running via dotnet test or dotnet run, not just in my IDE</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes [Bug]: Generic DependsOn not working #4245

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[Copilot]

Pull request overview

This PR fixes a bug where the generic DependsOn<T> attribute was ignoring the type parameter T, treating cross-class dependencies as same-class dependencies. The root cause was that the source generator only examined constructor arguments, missing the generic type argument which is stored separately on the attribute class itself.

Key Changes

• The source generator now extracts the type argument from AttributeClass.TypeArguments[0] when the attribute is generic
• Adds handling for all three generic constructor overloads: DependsOn<T>(), DependsOn<T>(methodName), and DependsOn<T>(methodName, parameterTypes)
• Integration tests verify both generic dependency patterns work correctly

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
TUnit.Core.SourceGenerator/Generators/TestMetadataGenerator.cs	Modified GenerateTestDependency() to detect generic DependsOnAttribute<T> and extract the type argument, then generate appropriate TestDependency objects with the correct ClassType for all three constructor overloads
TUnit.TestProject/GenericDependsOnTests.cs	Added integration tests for both DependsOn<T>(methodName) and DependsOn<T>() patterns using timing assertions to verify dependency ordering is respected

[Copilot]

Write to static field from instance method, property, or constructor.

[Copilot]

Write to static field from instance method, property, or constructor.

[Copilot]

Write to static field from instance method, property, or constructor.

[Copilot]

Write to static field from instance method, property, or constructor.

Suggested change

	[Test, DependsOn<GenericDependsOnTestsClassB>]
	public async Task Test2()
	{
	_test2Start = TestContext.Current!.Execution.TestStart!.Value.DateTime;
	private static void SetTest2Start(DateTime value)
	{
	_test2Start = value;
	}
	[Test, DependsOn<GenericDependsOnTestsClassB>]
	public async Task Test2()
	{
	SetTest2Start(TestContext.Current!.Execution.TestStart!.Value.DateTime);