Avoid modifying method on HEAD requests#353
Open
bltavares wants to merge 1 commit intothomseddon:masterfrom
Open
Avoid modifying method on HEAD requests#353bltavares wants to merge 1 commit intothomseddon:masterfrom
bltavares wants to merge 1 commit intothomseddon:masterfrom
Conversation
Traefik sends a forward auth request for every request, including HEAD methods, in order to validate if a request can continue. Due to Go HTTP client being strict to the HTTP SPEC, the response of a HEAD does not include a body, while Traefik expects a validation response to be embedded, causing errors. To mitigate this, when a X-Forwarded-Method is set as HEAD, we'll avoid modifying the HTTP Method response in order to send a body back, allowing head requests to by validated. This is necessary even if an allow rule is set, otherwhise it will fail as well. Mitagates: thomseddon#156
|
Hi! I am facing exactly the problem described in #156. Does anything speak against merging this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Traefik sends a forward auth request for every request, including HEAD methods, in order to validate if a request can continue.
Due to Go HTTP client being strict to the HTTP SPEC, the response of a HEAD does not include a body, while Traefik expects a validation response to be embedded, causing errors.
To mitigate this, when a X-Forwarded-Method is set as HEAD, we'll avoid modifying the HTTP Method response in order to send a body back, allowing head requests to by validated.
This is necessary even if an allow rule is set, otherwhise it will fail as well.
Mitagates: #156