Skip to content

BufferAttribute: add gpuType#469

Merged
Methuselah96 merged 2 commits intothree-types:devfrom
CodyJasonBennett:gputype
Jun 4, 2023
Merged

BufferAttribute: add gpuType#469
Methuselah96 merged 2 commits intothree-types:devfrom
CodyJasonBennett:gputype

Conversation

@CodyJasonBennett
Copy link
Contributor

Why

Follow-up to mrdoob/three.js#26084.

What

I've added gpuType to BufferAttribute to formalize its usage. @link FloatType doesn't work for the JSDoc though. Maybe we export type aliases for them -- export type FloatType = typeof FloatType;

Checklist

  • Checked the target branch (current goes master, next goes dev)
  • Added myself to contributors table
  • Ready to be merged

@Methuselah96 Methuselah96 changed the base branch from master to dev June 4, 2023 14:12
@Methuselah96 Methuselah96 mentioned this pull request Jun 4, 2023
45 tasks
Copy link
Contributor

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Methuselah96 Methuselah96 merged commit 5f61315 into three-types:dev Jun 4, 2023
Methuselah96 added a commit that referenced this pull request Jun 29, 2023
* BufferAttribute: add gpuType

* Shorten line

---------

Co-authored-by: Nathan Bierema <nbierema@gmail.com>
MykhailoStrelnykov pushed a commit to Chronos-Samples/three-ts-types that referenced this pull request Dec 22, 2025
* BufferAttribute: add gpuType

* Shorten line

---------

Co-authored-by: Nathan Bierema <nbierema@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants