Skip to content

Improve number formatting #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hjiangsu merged 1 commit into from
Jan 3, 2024
Merged

Improve number formatting #1008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/search/pages/search_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ import 'package:thunder/utils/global_context.dart';
import 'package:thunder/utils/instance.dart';
import 'package:flutter_gen/gen_l10n/app_localizations.dart';
import 'package:thunder/utils/navigate_user.dart';
import 'package:thunder/utils/numbers.dart';

class SearchPage extends StatefulWidget {
const SearchPage({super.key});
Expand Down Expand Up @@ -736,7 +737,7 @@ class _SearchPageState extends State<SearchPage> with AutomaticKeepAliveClientMi
),
),
Text(
' · ${communityView.counts.subscribers}',
' · ${formatLongNumber(communityView.counts.subscribers)}',
semanticsLabel: l10n.countSubscribers(communityView.counts.subscribers),
),
const SizedBox(width: 4),
Expand Down
15 changes: 8 additions & 7 deletions lib/utils/numbers.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
String formatNumberToK(int number) {
if (number.abs() > 999) {
return '${(number.sign * number.abs() / 1000).toStringAsFixed(1)}K';
} else {
return (number.sign * number.abs()).toString();
}
}
import 'package:intl/intl.dart';

final NumberFormat _compactFormatter = NumberFormat.compact();
final NumberFormat _longFormatter = NumberFormat.decimalPatternDigits(decimalDigits: 0);

String formatNumberToK(int number) => _compactFormatter.format(number);

String formatLongNumber(int number) => _longFormatter.format(number);