Skip to content

Account selector improvements and minor fixes#1035

Merged
hjiangsu merged 3 commits intodevelopfrom
refactor/profile-selector-modal
Jan 11, 2024
Merged

Account selector improvements and minor fixes#1035
hjiangsu merged 3 commits intodevelopfrom
refactor/profile-selector-modal

Conversation

@hjiangsu
Copy link
Copy Markdown
Member

@hjiangsu hjiangsu commented Jan 10, 2024

Pull Request Description

This PR adds the following changes/fixes:

  • Fixes an issue where long pressing on the account option on the bottom navigation bar would often times show the tooltip instead of the account selector
  • Fixes a minor visual bug where the drag handle of the account selector was mismatched
  • Refactors the account selector modal to use slivers, and moved add account/instance to the top

Let me know what you think of the changes!

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

simulator_screenshot_9F30DD9B-8AE1-4C93-B5B6-37BF005D14EE

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Copy Markdown
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

My only concern is that the "add anonymous account" button might not be obvious and people might miss that the feature exists. Maybe in the future, we can have a single button, and within the account creation dialog, we can have an option to switch it to anonymous, which will just hide the user fields.

@hjiangsu
Copy link
Copy Markdown
Member Author

hjiangsu commented Jan 11, 2024

My only concern is that the "add anonymous account" button might not be obvious and people might miss that the feature exists. Maybe in the future, we can have a single button, and within the account creation dialog, we can have an option to switch it to anonymous, which will just hide the user fields.

I tried to look for some more distinguishable icons for the anonymous accounts, but was unable to find any that suited. I do think your idea of having this in the account creation dialog makes sense! I'll merge this in and we can think about implementing this.

@hjiangsu hjiangsu merged commit ee88079 into develop Jan 11, 2024
@hjiangsu hjiangsu deleted the refactor/profile-selector-modal branch January 11, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants