Skip to content

Navigate to new post after creation#1044

Merged
hjiangsu merged 2 commits intothunder-app:developfrom
micahmo:feature/navigate-to-new-post
Jan 17, 2024
Merged

Navigate to new post after creation#1044
hjiangsu merged 2 commits intothunder-app:developfrom
micahmo:feature/navigate-to-new-post

Conversation

@micahmo
Copy link
Copy Markdown
Member

@micahmo micahmo commented Jan 12, 2024

Pull Request Description

This PR adds the ability to navigate to a new post directly after creation. This is especially useful when creating from the main feed, because the new post won't appear in the feed.

Review without whitespace.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

This demo illustrates that the snackbar is shown and navigation to the post works after creating a new post from...

  • The main feed FAB
  • Cross-post menu
  • Cross-post widget
  • External share
qemu-system-x86_64_kcMFUMl3K7.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Copy Markdown
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit a6f5ded into thunder-app:develop Jan 17, 2024
@micahmo micahmo deleted the feature/navigate-to-new-post branch January 17, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants