Add a notification page to display individual messages#1069
Merged
hjiangsu merged 5 commits intothunder-app:developfrom Jan 22, 2024
Merged
Add a notification page to display individual messages#1069hjiangsu merged 5 commits intothunder-app:developfrom
hjiangsu merged 5 commits intothunder-app:developfrom
Conversation
ggichure
reviewed
Jan 19, 2024
ggichure
approved these changes
Jan 19, 2024
hjiangsu
approved these changes
Jan 19, 2024
Member
hjiangsu
left a comment
There was a problem hiding this comment.
Looks good to me! Just a couple of comments.
I'll trust that it works on Android since I can't test it out myself!
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR is a followup to the recent notifications PR, which adds the ability to navigate directly to a specific reply from a notification. This is accomplished by pushing a new page onto the navigation stack, which is especially useful when the user has already navigated in the app to another page. Previously, opening a notification would scroll to the Inbox tab, but if there were another page open, that action would not be visible. Now a new page is pushed on top.
If the user clicks on a group notification, the page will show all unread replies. If the user clicks on a specific reply, the page will show only that reply (similar to opening an email). Also note that it will show that reply whether it is unread or not (in case the user happened to mark it read outside of Thunder). From there, the user can perform all the standard actions with the reply.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Opening group notification
qemu-system-x86_64_Yu9KuTiWRZ.mp4
Opening single notification
qemu-system-x86_64_troMOP0FlS.mp4
Checklist
semanticLabels where applicable for accessibility?