Fixed issue where feed FAB can be triggered on other pages#1085
Merged
Fixed issue where feed FAB can be triggered on other pages#1085
Conversation
micahmo
approved these changes
Jan 25, 2024
Member
micahmo
left a comment
micahmo
left a comment
There was a problem hiding this comment.
LGTM.
Does the FAB still appear on communities that are opened from another page?
Member
Author
It still works when navigating to a community on a new page since that uses a separate feed FAB! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This is a small PR which fixes an issue where the feed FAB can be triggered from another screen. This is because the FAB is still on screen, but is just invisible.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?