Skip to content

Colorized usernames#1092

Merged
hjiangsu merged 4 commits intothunder-app:developfrom
ggichure:feature/colorized_usernames
Feb 5, 2024
Merged

Colorized usernames#1092
hjiangsu merged 4 commits intothunder-app:developfrom
ggichure:feature/colorized_usernames

Conversation

@ggichure
Copy link
Copy Markdown
Collaborator

Pull Request Description

This PR adds support for colorized usernames. Using colorScheme.secondary else textTheme.bodyLarge?.color.

Issue Being Fixed

Issue Number: #240

Screenshots / Recordings

w2

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Copy Markdown
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@hjiangsu hjiangsu merged commit 2122ec0 into thunder-app:develop Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants