New comment indicator - Change to more than instead of not zero to avoid negative new comments#1103
Merged
hjiangsu merged 2 commits intothunder-app:developfrom Feb 5, 2024
Merged
Conversation
Closed
micahmo
approved these changes
Jan 31, 2024
Member
micahmo
left a comment
micahmo
left a comment
There was a problem hiding this comment.
LGTM, thanks for the quick fix!
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Change to more than instead of not zero to not show negative new comments
Issue Being Fixed
Comment indicator would trigger on negative new comments
Checklist