Merged
Conversation
ggichure
approved these changes
Feb 2, 2024
hjiangsu
reviewed
Feb 12, 2024
Member
hjiangsu
left a comment
There was a problem hiding this comment.
Sorry for the delay in reviewing this. LGTM (just merge conflicts to handle and it should be good 😊)!
hjiangsu
approved these changes
Feb 12, 2024
Member
Author
No problem! Should be all set now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds the ability to initiate a search from a community. We already have the ability to search communities from the main search page, but I often find that I'm already in a community and want to search just that community without losing my spot. Now there's a new menu item which will push a new search page on the stack.
The community-specific search page will have a few limitations.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
qemu-system-x86_64_jM8TXf31bU.mp4
Checklist
semanticLabels where applicable for accessibility?