A few comment/image improvements#1390
Merged
hjiangsu merged 2 commits intothunder-app:developfrom May 31, 2024
Merged
Conversation
hjiangsu
approved these changes
May 30, 2024
Member
hjiangsu
left a comment
There was a problem hiding this comment.
Thanks for doing this - the comment section jumping was also somewhat annoying for me, but I never had the chance to look into it further!
LGTM - just one comment!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR makes a couple of changes to comments and images.
AnimatedSize. This means when anything changes with respect to the height of the comments (an example is viewing the raw markdown), it will more nicely animate.Hopefully that all makes sense!
Screenshots
Bad Image Placeholder
Image Load
Before
image-load-in-before.mp4
After
image-load-in-after.mp4