Skip to content

Fix superscript/subscript parsing#1395

Merged
hjiangsu merged 1 commit intothunder-app:developfrom
micahmo:fix/markdown-parsing
May 30, 2024
Merged

Fix superscript/subscript parsing#1395
hjiangsu merged 1 commit intothunder-app:developfrom
micahmo:fix/markdown-parsing

Conversation

@micahmo
Copy link
Copy Markdown
Member

@micahmo micahmo commented May 29, 2024

Pull Request Description

This is a small PR which fixes a markdown parsing issue I noticed where superscript/subscript would be rendered inside of inline code block (when they shouldn't be).

As a nice side-effect, I believe this also fixes the problem that had been commented in code as not supported.
This is a text^superscript^ and this is a text~subscript~

I also re-tested with this comment, and everything still looks good!

Demo

Found in https://programming.dev/comment/9864839

Before After
image image

Copy link
Copy Markdown
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu added this to the 0.5.0 milestone May 30, 2024
@hjiangsu hjiangsu merged commit fb91938 into thunder-app:develop May 30, 2024
@micahmo micahmo deleted the fix/markdown-parsing branch May 30, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants