Skip to content

Fix post page crosspost height#1415

Merged
hjiangsu merged 1 commit intodevelopfrom
fix/post-crosspost-height
Jun 3, 2024
Merged

Fix post page crosspost height#1415
hjiangsu merged 1 commit intodevelopfrom
fix/post-crosspost-height

Conversation

@hjiangsu
Copy link
Copy Markdown
Member

@hjiangsu hjiangsu commented Jun 3, 2024

Pull Request Description

This is a super small PR which fixes an issue where the crosspost height was too tall in the post view. This issue may be prevalent outside of the post page refactor since the logic was under cross_posts which was untouched by #1363. (however, I haven't been able to find an example of this during testing)

Issue Being Fixed

Issue Number: #1413

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Copy Markdown
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a bunch!

@hjiangsu hjiangsu merged commit b07b701 into develop Jun 3, 2024
@hjiangsu hjiangsu deleted the fix/post-crosspost-height branch June 3, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants