Conversation
micahmo
left a comment
There was a problem hiding this comment.
This is awesome! I love all the new settings, the reorganization of the content management section, the use of the FAB and tabs.
Here are just a few initial thoughts from watching the demo videos. Any/all of these things can be separate.
- In General Settings, should "Default Comment Sort Type" go under "Comments" rather than "Feed"?
- In the list of settings you said you didn't add because they mostly related to the web UI, one I disagree with is "Bot account toggle" which marks your own account as being a bot. I see a lot of people have this on by accident, so it might be nice to allow it to be toggled off in Thunder.
- I believe bios support markdown, so you might want to consider sanitizing the content for the subtitle. You might also want to truncate it, since bios may be long.
|
Alright, I addressed most of the comments you had!
For this, I expanded the text field to allow for multiple lines, and truncated/sanitized the bio preview. For now, it's still using a simple text field even though markdown is supported but we can add in markdown support for bios in a future PR! |
|
Awesome, the changes look good!! |
|
@hjiangsu I noticed a slight quirk here.
|

Pull Request Description
This PR adds a bunch of additional account settings that sync up with Lemmy, including:
As a result of this, I also cleaned up the user settings page and moved discussion languages and blocking to separate pages.
Note: I opted to only sync settings that adjust underlying logic. I left out most of the settings which change the UI in some way (since I believe that's better handled in the app settings). These are the settings I omitted from including:
Some settings that are still missing but would be good to add in the future include:
I did some basic testing for all of the new settings introduced, but there might still be some edge cases I missed!
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Account Settings
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-06-08.at.11.13.51.1.mp4
Discussion Languages
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-06-08.at.11.19.11.mp4
Block Management
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-06-08.at.11.22.19.mp4
Feed Account Sort/Type
Keep an eye out on the feed sort type
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-06-08.at.11.29.09.mp4
Checklist
semanticLabels where applicable for accessibility?