Skip to content

Fix experimental post page comment pagination#1445

Merged
hjiangsu merged 1 commit intodevelopfrom
fix/post-page-comment-pagination
Jun 13, 2024
Merged

Fix experimental post page comment pagination#1445
hjiangsu merged 1 commit intodevelopfrom
fix/post-page-comment-pagination

Conversation

@hjiangsu
Copy link
Copy Markdown
Member

Pull Request Description

I forgot to add in pagination for comments for the new experimental post page. This PR fixes that!

Issue Being Fixed

Issue Number: #1413

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu hjiangsu changed the title Fix issue where experimental post page was not paginating comments Fix experimental post page comment pagination Jun 12, 2024
Copy link
Copy Markdown
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit ad83dbc into develop Jun 13, 2024
@hjiangsu hjiangsu deleted the fix/post-page-comment-pagination branch June 13, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants