Add support for hiding posts#1484
Merged
hjiangsu merged 3 commits intothunder-app:developfrom Jul 16, 2024
Merged
Conversation
hjiangsu
approved these changes
Jul 13, 2024
Member
hjiangsu
left a comment
There was a problem hiding this comment.
Just a minor comment! Otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds support for the ability to hide posts introduced in Lemmy 0.19.4.
Unfortunately there does not seem to be a Lemmy account setting for whether to show/hide hidden posts in the feed, so for now I've added a Thunder setting. But we can migrate this to an account setting if it ever becomes available.
Notes:
Issue Being Fixed
Issue Number: #1447
Screenshots / Recordings
Demo 1: Hide via swipe and button.
Demo1.mp4
Demo 2: Hide via swipe and button, respecting show hidden. Then unhide.
Demo2.mp4
Demo 3: Swipe and button are not visible on older instances.
Demo3.mp4
Checklist
semanticLabels where applicable for accessibility?