docs(adr): add ADR for api internal split #10198
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmontwe
changed the title
wmontwe
force-pushed
the
chore-adr-api-internal-split
branch
2 times, most recently
from
847ac40 to
b2a404d
Compare
wmontwe
force-pushed
the
chore-adr-api-internal-split
branch
from
b2a404d to
dee53a6
Compare
wmontwe
added
the
merge block: soft freeze
wmontwe
changed the title
wmontwe
removed
the
merge block: soft freeze
rafaeltonholo
approved these changes
Dec 8, 2025
Member
rafaeltonholo
left a comment
rafaeltonholo
left a comment
There was a problem hiding this comment.
LGTM. Thanks for creating this ADR! I've left a few comments, but I'm fine with what is already described.
Comment on lines
+36
to
+40
| Put only stable, intentionally shared contracts in `api`: | ||
| - Public interfaces and abstractions other features depend on (e.g., repositories, use cases, service interfaces). | ||
| - Data contracts exchanged across features (DTOs/value objects). | ||
| - Navigation contracts and events that other features can trigger/observe. | ||
| - DI entry points/interfaces needed by composition modules (`:app-common`, app modules). |
Member
There was a problem hiding this comment.
There are a few cases where we might need to expose UI implementations on the api module (e.g.: :feature:notification:api, :core:ui:compose:designsystem:api).
Unless we start using fun interfaces implementations and koin injection inside the Composables which uses these shared ui implementations, I believe we should include this exception here.
Member
There was a problem hiding this comment.
Another option could be having an api-ui or ui-api module for these cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10197