-
Notifications
You must be signed in to change notification settings - Fork 5
feat(filesystem): fatfs service #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: koichiimai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: koichiimai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi Imai <[email protected]>
Signed-off-by: Koichi <[email protected]>
ytakano
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
This PR introduces an asynchronous file system service using a channel-based, client-server architecture.
It provides a user-facing FileDescriptor API that communicates with a backend MemoryFileSystemServer. All operations like open, read, and write are async functions.
Architecture Overview
Single Request Channel: The MemoryFileSystemServer listens on a single, shared channel for all incoming requests (Open, Read, Write, etc.).
Per-FD Response Channel: When a file is opened or created, a unique response channel is established for that specific file descriptor. The server uses this dedicated channel to send all subsequent I/O results (ReadResult, WriteBytes, etc.) back to the correct FileDescriptor instance, ensuring responses are routed correctly.
File System Operations Supported in this PR
The names and types of commands exchanged between async_lib and the service will be added or modified as we introduce new features and support in the future.
Related links
How was this PR tested?
Notes for reviewers
In the current implementation, all requests from async_lib to the service use a single channel that was created during the service's initialization. However, it's not ideal for operations on all file descriptors to use the same channel, as an operation on one file descriptor by a task could affect another task's operation on a different file descriptor.
To solve this, we would need to create a separate, dedicated channel for file system operations for each file descriptor after it's generated by open, create, etc. But, this would require the service to handle I/O multiplexing (using select), which would increase the code's complexity. Therefore, we'll merge it as-is for now and fix this later.