fix(filesystem): rename Error to IOError in AsyncFilesystem #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Koichi <[email protected]>
veqcc
approved these changes
Jul 1, 2025
ytakano
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the AsyncFilesystem trait, each implementing filesystem needs to provide an associated type for Error. However, this Error type is actually passed as the generic type E specifically for VfsError's IoError.
Therefore, I've renamed it from a generic "Error" to "IOError". This makes its purpose much clearer and more explicit, as it specifically represents I/O-related errors within the filesystem context.
Related links
#548 (VfsError introducing PR)
#511
How was this PR tested?
Notes for reviewers