Update RuboCop version#178
Merged
kapoorlakshya merged 1 commit intotitusfortner:masterfrom Aug 11, 2020
Merged
Conversation
Collaborator
|
Hi @utkarsh2102, thank you for your contribution! I just fixed the I also fixed the unit test failure blocking your PR (see 6d39862), so please rebase on top of |
Contributor
Author
|
Oh wow, your fix for the violation is pretty neat! 💯 |
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
utkarsh2102
force-pushed
the
update-rubocop
branch
from
e7f5bc6 to
f5a46df
Compare
utkarsh2102
changed the title
Collaborator
|
@utkarsh2102 Thank you for updating the PR! Merging... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @kapoorlakshya,
Thanks for taking care of this so far! 🚀
However, there was one offense left, which is what this PR fixes.
(and also updates to use latest RuboCop!
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>