Make WSL detection more generic#187
Merged
kapoorlakshya merged 1 commit intotitusfortner:masterfrom Dec 18, 2020
Merged
Conversation
Collaborator
|
@rbclark Thanks for your contribution! Will try to release all the recent changes this weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On WSL2, the contents of
/proc/versionseem to have changed slightly, the command currently in webdrivers currently returns false:Full contents for completeness:
Unfortunately this does not seem to fix all of the issues, although I am unsure if the rest of the issues are in the webdrivers gem or not. I am still receiving a
Selenium::WebDriver::Error::WebDriverError: unable to connect to chromedriver 127.0.0.1:9515error when trying to run on WSL2 with a pretty barebones Rails system test setup.