rename Edge classes to support Selenium 4 beta#206
Merged
titusfortner merged 1 commit intomasterfrom Feb 26, 2021
Merged
Conversation
kapoorlakshya
approved these changes
Feb 26, 2021
This was referenced Mar 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Selenium 3.142.7 we used
Edgeto refer to the old Edge HTML implementation.When we switched to working on Selenium 4 we split them into
EdgeChromeandEdgeHtmlFor Selenium 4 beta, we've dropped support for Edge HTML entirely, so everything that was
EdgeChromeis now justEdge.The current test runs will be passing because the specs skip them incorrectly now. (take a look at skipped tests: https://github.com/titusfortner/webdrivers/runs/1990772141)
This PR renames
EdgeChrometoEdge.The only people using this class have been using it with Selenium 4 alpha because it isn't supported at all in the latest production version of Selenium.
This code is not backward compatible with Selenium 4 alpha, but I think the correct response is for those people to update to using Selenium 4 beta rather than this gem giving warnings or upgrade paths.
Any concerns?