Skip to content

Fix bug when converting Vectors containing None (or null) into SQL #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tminglei merged 2 commits into from
Mar 10, 2026
Merged

Fix bug when converting Vectors containing None (or null) into SQL #815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afd9fd2
Add test to reproduce issue with null/None in a Vector
aelred Feb 16, 2026
66f63d0
Handle Vectors as well as Lists in PgTokenHelper isArray
aelred Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/scala/com/github/tminglei/slickpg/utils/PgTokenHelper.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ object PgTokenHelper {
def isArray(token: Token): Boolean = token match {
case GroupToken(mList) =>
mList match {
case Open("{") :: _ => true
case Open("{") +: _ => true
case _ => false
}
case _ => false
Expand Down
14 changes: 14 additions & 0 deletions core/src/test/scala/com/github/tminglei/slickpg/utils/PgTokenHelperSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,5 +340,19 @@ class PgTokenHelperSuite extends AnyFunSuite {

val expected2 = """{{11,12,13},{21,22,23}}"""
assert(pgStr2 === expected2)

///
val input3 = GroupToken(List(Open("{"), Null, Close("}")))
val pgStr3 = createString(input3)

val expected3 = """{null}"""
assert(pgStr3 === expected3)

///
val input4 = GroupToken(Vector(Open("{"), Null, Close("}")))
val pgStr4 = createString(input4)

val expected4 = """{null}"""
assert(pgStr4 === expected4)
}
}
Loading