Skip to content

Fix missing sms system prompt#168

Merged
tmo1 merged 1 commit intotmo1:masterfrom
andr5w:fix-missing-sms-system-prompt
Mar 11, 2024
Merged

Fix missing sms system prompt#168
tmo1 merged 1 commit intotmo1:masterfrom
andr5w:fix-missing-sms-system-prompt

Conversation

@andr5w
Copy link
Copy Markdown
Contributor

@andr5w andr5w commented Mar 10, 2024

Fixes an issue where the system dialog for selecting a default SMS application did not appear on some android systems when a user taps "Import Messages".

Fixes an issue where the system dialog for selecting a default SMS application did not appear on some android systems when a user taps "Import Messages".
@andr5w
Copy link
Copy Markdown
Contributor Author

andr5w commented Mar 10, 2024

This should fix #167.

@tmo1
Copy link
Copy Markdown
Owner

tmo1 commented Mar 11, 2024

Thank you! I should have added the <uses-feature> element a while ago, since Android Studio was urging it.

Regarding the exported value for .ComposeSmsActivity, for some reason the official documentation doesn't include the exported attribute at all, so I suppose that when I added it, I went with false, but I see that Fossify has true.

Did you test these two changes separately to see which one fixes the problem?

@tmo1 tmo1 linked an issue Mar 11, 2024 that may be closed by this pull request
@andr5w
Copy link
Copy Markdown
Contributor Author

andr5w commented Mar 11, 2024

No worries. Setting the exported value for .ComposeSmsActivity to true fixes the linked issue. I added <uses-feature> for the same reason you mentioned - it's not required for this fix (I did test this) but I figured it'd be a good inclusion from a maintenance perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not Listed In Default SMS App

2 participants