fix: import crashes on miui, #103

[askorbinovaya-kislota]

when device has miui, it now removes the "deleted" and "sync_state" fields

i've tested it on my device and it works now

[askorbinovaya-kislota]

there is a better way to get system properties with reflection, if you don't want to invoke getprop: https://github.com/Aefyr/SAI/blob/55505d231b1390e824d1cc0c8f4fa35fd4677105/app/src/main/java/com/aefyr/sai/utils/Utils.java#L68

and this might be interesting: https://github.com/Aefyr/SAI/blob/master/app/src/main/java/com/aefyr/sai/utils/MiuiUtils.java (uses the same method to detect miui)

[tmo1]

Looks good, but a couple of comments:

• Is it really necessary to check for MIUI at all, or can we just always drop the two problematic fields on import?
• The app already has a framework for including and excluding fields on import - the mutable set smsColumns, from which we remove any field that we don't want to import. I think it would be cleaner, and likely more efficient, to just do a one-time removal of the two problematic fields from smsColumns rather than issue two remove calls for each imported message.

[askorbinovaya-kislota]

Is it really necessary to check for MIUI at all, or can we just always drop the two problematic fields on import?

i didn't know how are those fields used, checked for miui just to be sure nothing changes on other roms

i'll update it based on what you suggested

[tmo1]

i didn't know how are those fields used, checked for miui just to be sure nothing changes on other roms

I've never seen those two fields outside of MIUI exports, so I tentatively assume that they're some kind of MIUI proprietary extension to Android's SMS storage format, but I admit that I'm not really sure.

[tmo1]

Thank you!

Your original commit removed the MIUI fields only from SMS messages, while your subsequent commit removes them from MMS messages as well. Are these fields present in MMS messages?

[askorbinovaya-kislota]

Are these fields present in MMS messages?

just checked - yes. and import fails with the same error when fields were not deleted

[tmo1]

Thank you!