MessageFiltersActivity: Enable edge-to-edge and remove editbox_background#305
MessageFiltersActivity: Enable edge-to-edge and remove editbox_background#305tmo1 merged 3 commits intotmo1:masterfrom
Conversation
…ound * Fixes the status bar having light text on a light background when the OS is set to light mode. * Fixes spinners having light text on a light background when the OS is set to dark mode. (@android:drawable/editbox_background is not day/night-aware.) Fixes: #304 Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
Should this be "dark mode"?
It's almost certainly fine, but if it's not too much trouble, would you be able to post before and after screenshots? |
|
Sure! Happy to post screenshots.
In this case, I did mean light mode. Without edge-to-edge enabled, Android was showing white text in the status bar on top of a white background. Before: Screenshot_20250925-203104 After: Screenshot_20250925-203212
Before (dialog): Screenshot_20250925-203249 After (dialog): Screenshot_20250925-203311 Before (activity): Screenshot_20250925-203256 After (activity): Screenshot_20250925-203316 Using the default styling does make the dialog box a bit cramped compared to before. Let me see if I can make a small change to improve it. |
…ws equally sized Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
|
What do you think about this? Screenshot_20250925-205055 (commit fe52109) This adds Android's default dialog padding, makes the fields fill the width, and makes each row have equal heights. |
|
Thanks as always for doing all this!
It's pretty good. I think that I prefer the versions that show boxes / rectangles around the values in the dialog, but I don't have very strong feelings on the matter. |
Sounds good. I'll play around with this more tomorrow and see if I can get that to work. |
…d Spinners have similar styles Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
|
I've added commit cad32c5, which adds borders around the values and makes the style of the EditText match the Spinners, similar to how it was before. I have no idea if this is the right way to do things, but this is how it looks: Light mode: Screenshot_20250926-170152 Dark mode: Screenshot_20250926-170143 |
|
Looks good - thanks! |
@android:drawable/editbox_backgroundis not day/night-aware.)Fixes: #304