Skip to content

MessageFiltersActivity: Enable edge-to-edge and remove editbox_background#305

Merged
tmo1 merged 3 commits intotmo1:masterfrom
chenxiaolong:message-filter
Oct 1, 2025
Merged

MessageFiltersActivity: Enable edge-to-edge and remove editbox_background#305
tmo1 merged 3 commits intotmo1:masterfrom
chenxiaolong:message-filter

Conversation

@chenxiaolong
Copy link
Copy Markdown
Contributor

  • Fixes the status bar having light text on a light background when the OS is set to light mode.
  • Fixes spinners having light text on a light background when the OS is set to dark mode. (@android:drawable/editbox_background is not day/night-aware.)
    • NOTE: This does change how the UI looks a little bit. If this is not desired, I can try to find a different approach.

Fixes: #304

…ound

* Fixes the status bar having light text on a light background when the
  OS is set to light mode.
* Fixes spinners having light text on a light background when the OS is
  set to dark mode. (@android:drawable/editbox_background is not
  day/night-aware.)

Fixes: #304

Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
@tmo1
Copy link
Copy Markdown
Owner

tmo1 commented Sep 25, 2025

Fixes the status bar having light text on a light background when the OS is set to light mode.

Should this be "dark mode"?

This does change how the UI looks a little bit. If this is not desired, I can try to find a different approach.

It's almost certainly fine, but if it's not too much trouble, would you be able to post before and after screenshots?

@chenxiaolong
Copy link
Copy Markdown
Contributor Author

Sure! Happy to post screenshots.

Should this be "dark mode"?

In this case, I did mean light mode. Without edge-to-edge enabled, Android was showing white text in the status bar on top of a white background.

Before: Screenshot_20250925-203104

After: Screenshot_20250925-203212

It's almost certainly fine, but if it's not too much trouble, would you be able to post before and after screenshots?

Before (dialog): Screenshot_20250925-203249

After (dialog): Screenshot_20250925-203311

Before (activity): Screenshot_20250925-203256

After (activity): Screenshot_20250925-203316

Using the default styling does make the dialog box a bit cramped compared to before. Let me see if I can make a small change to improve it.

…ws equally sized

Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
@chenxiaolong
Copy link
Copy Markdown
Contributor Author

What do you think about this? Screenshot_20250925-205055 (commit fe52109)

This adds Android's default dialog padding, makes the fields fill the width, and makes each row have equal heights.

@tmo1
Copy link
Copy Markdown
Owner

tmo1 commented Sep 26, 2025

Thanks as always for doing all this!

What do you think about this?

It's pretty good. I think that I prefer the versions that show boxes / rectangles around the values in the dialog, but I don't have very strong feelings on the matter.

@chenxiaolong
Copy link
Copy Markdown
Contributor Author

I think that I prefer the versions that show boxes / rectangles around the values in the dialog, but I don't have very strong feelings on the matter.

Sounds good. I'll play around with this more tomorrow and see if I can get that to work.

…d Spinners have similar styles

Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
@chenxiaolong
Copy link
Copy Markdown
Contributor Author

I've added commit cad32c5, which adds borders around the values and makes the style of the EditText match the Spinners, similar to how it was before. I have no idea if this is the right way to do things, but this is how it looks:

Light mode: Screenshot_20250926-170152

Dark mode: Screenshot_20250926-170143

@tmo1 tmo1 merged commit 233da85 into tmo1:master Oct 1, 2025
5 checks passed
@tmo1
Copy link
Copy Markdown
Owner

tmo1 commented Oct 1, 2025

Looks good - thanks!

@chenxiaolong chenxiaolong deleted the message-filter branch October 1, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Message filters are unreadable in dark mode.

2 participants