Skip to content

Fix!: produce TableAlias instead of Alias for USING in merge builder #5911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgesittas merged 1 commit into from
Sep 18, 2025
Merged

Fix!: produce TableAlias instead of Alias for USING in merge builder #5911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sqlglot/expressions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8317,6 +8317,9 @@ def merge(
if returning:
merge = merge.returning(returning, dialect=dialect, copy=False, **opts)

if isinstance(using_clause := merge.args.get("using"), Alias):
using_clause.replace(alias_(using_clause.this, using_clause.args["alias"], table=True))

return merge


Expand Down
14 changes: 14 additions & 0 deletions tests/dialects/test_oracle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,3 +777,17 @@ def test_utc_time(self):
self.validate_identity("UTC_TIME(6)").assert_is(exp.UtcTime)
self.validate_identity("UTC_TIMESTAMP()").assert_is(exp.UtcTimestamp)
self.validate_identity("UTC_TIMESTAMP(6)").assert_is(exp.UtcTimestamp)

def test_merge_builder_alias(self):
merge_stmt = exp.merge(
"WHEN MATCHED THEN UPDATE SET my_table.col1 = source_table.col1",
"WHEN NOT MATCHED THEN INSERT (my_table.id, my_table.col1) VALUES (source_table.id, source_table.col1)",
into="my_table",
using="(SELECT * FROM something) source_table",
on="my_table.id = source_table.id",
dialect="oracle",
)
self.assertEqual(
merge_stmt.sql("oracle"),
"MERGE INTO my_table USING (SELECT * FROM something) source_table ON my_table.id = source_table.id WHEN MATCHED THEN UPDATE SET my_table.col1 = source_table.col1 WHEN NOT MATCHED THEN INSERT (my_table.id, my_table.col1) VALUES (source_table.id, source_table.col1)",
)