Skip to content

Allow extra keyword arguments to requests.get() in get() #159

Merged
WardBrian merged 1 commit intotoddrob99:developfrom
WardBrian:extra-requests-params
Mar 27, 2025
Merged

Allow extra keyword arguments to requests.get() in get() #159
WardBrian merged 1 commit intotoddrob99:developfrom
WardBrian:extra-requests-params

Conversation

@WardBrian
Copy link
Collaborator

Closes #155

@WardBrian WardBrian linked an issue Mar 27, 2025 that may be closed by this pull request
@WardBrian
Copy link
Collaborator Author

To test:

import statsapi

# enable logging
from http.client import HTTPConnection
HTTPConnection.debuglevel = 1
import logging
logging.basicConfig(level=logging.DEBUG)


statsapi.get("schedule", {'sportId':1}, request_kwargs={"headers":{"Accept-Encoding": "gzip"}})

@WardBrian WardBrian merged commit 8da37f9 into toddrob99:develop Mar 27, 2025
@WardBrian WardBrian mentioned this pull request Apr 1, 2025
toddrob99 added a commit that referenced this pull request Apr 4, 2025
Features:

- New uniform endpoints `game_uniforms` and `team_uniforms` (#154)
- `schedule()` supports the `season` argument to get an entire season's games at once (#149)
- `player_stats()` and `player_stats_data()` support the `season` argument to get previous seasons of stats (#161)
- `get()` now accepts a `requests_kwargs` dict which are passed as extra arguments to `requests.get()` (#159)

Bug fixes:

- Fixed the offseason behavior of the `latest_season()` function to return the upcoming season, not just whatever the most recent in MLB's data is (#157)
- `schedule()` supports passing `include_series_status=False` to not request the series status from the endpoint, which can fail when requesting schedules covering large periods of time (#158)
@WardBrian WardBrian deleted the extra-requests-params branch April 4, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FR: Allow extra kwargs to underlying requests.get

1 participant