-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(i18n): update FR translate & corrections #14052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated Spanish and French i18n JSON resources (branding, grammar, added keys). Also modified Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/frontend/i18n/src/resources/fr.json (1)
906-906: Fix multiple typos in subscription expiration message.Two errors in this line: incorrect capitalization of "Votre" and misspelling of "abonnement":
Current:
"VOtre abonneemnt est valable jusqu'au {{expirationDate}}"Should be:
"Votre abonnement est valable jusqu'au {{expirationDate}}"
🧹 Nitpick comments (2)
packages/frontend/i18n/src/resources/fr.json (2)
605-606: Fix indentation and formatting anomalies.Several lines have inconsistent indentation that makes the file harder to maintain:
- Lines 605-606: Docx entry has unusual indentation
- Lines 705-706: Discord entry indentation misaligned
- Lines 2104-2112: Subscription section has formatting issues
Ensure all entries maintain consistent JSON indentation (2 spaces per level).
Also applies to: 705-706, 2104-2112
10-10: Consider cleaning up inconsistent trailing spaces on UI labels.Several entries retain trailing spaces that were left unmodified while others were cleaned up. For consistency, consider removing trailing spaces from all label entries:
Examples:
- Line 10:
"Cancel": "Annuler "(has trailing space)- Line 101:
"Select": "Sélectionner "(has trailing space)- Line 115:
"Text": "Texte "(has trailing space)This follows the pattern of corrections made elsewhere (e.g., line 20: "Créer " → "Créer", line 55: "Favoris " → "Favoris").
Also applies to: 101-101, 115-115, 118-118, 125-125
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
packages/frontend/i18n/src/resources/es.json(2 hunks)packages/frontend/i18n/src/resources/fr.json(26 hunks)
🔇 Additional comments (1)
packages/frontend/i18n/src/resources/es.json (1)
38-38: ✓ Branding consistency corrections approved.Both changes correctly update the Spanish translation capitalization from "AFFINE" to "AFFiNE" to match the proper brand name. These align with existing correct usages elsewhere in the file (e.g., lines 5, 334).
Also applies to: 566-566
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #14052 +/- ##
==========================================
- Coverage 57.15% 56.60% -0.55%
==========================================
Files 2757 2757
Lines 137727 137727
Branches 21148 21033 -115
==========================================
- Hits 78720 77965 -755
- Misses 56778 57498 +720
- Partials 2229 2264 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Added a complete French translation for several user interface elements.
Updated existing translation strings to improve consistency and clarity.
Corrected inaccurate or unclear wording in the language files.
Harmonized terminology to maintain a uniform vocabulary across the interface.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.