Add zero-copy make_mut#695
Conversation
|
Why is |
|
I mean I guess we could but we already have to handle the copy case in each to_mut vtable function so I dont really see the point in not using that. Plus it there is a small chance that a concurrent thread released the shared since we use acquire vs relaxed ordering. |
|
Sorry I didnt have to work on it more, I will try this week. @braddunbar if you have for a review I would appreciate 🙏 |
|
Oh, I missed the notification. Thanks for the ping! I'll take a look. |
|
@braddunbar @Darksonn Gentle ping :) |
|
@Darksonn Done the improvements |
|
@braddunbar @Darksonn Ready for another round :) |
braddunbar
left a comment
There was a problem hiding this comment.
I spent some time combing over this today and I can't find anything to complain about. Thank you @Sytten!
Supersede #687
Closes #611
This is my first time contributing to bytes and this is quite a change, do let me know if you want more tests.