Improve BytesMut::split suggestion#699
Merged
Darksonn merged 1 commit intotokio-rs:masterfrom Apr 25, 2024
M4SS-Code:bytesmut-split-mustuse-msg
Merged
Improve BytesMut::split suggestion#699Darksonn merged 1 commit intotokio-rs:masterfrom M4SS-Code:bytesmut-split-mustuse-msg
Darksonn merged 1 commit intotokio-rs:masterfrom
M4SS-Code:bytesmut-split-mustuse-msg
Conversation
Darksonn
approved these changes
Apr 25, 2024
Member
Darksonn
left a comment
Darksonn
left a comment
There was a problem hiding this comment.
You know, this makes me realize that advance could be simplified to call clear instead of set_len(0).
Contributor
Author
Yeah I had skipped |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporates the improvement from #698 into the
must_usesuggestion ofBytesMut::split.