fix: Include other Conventional Commit types#192
fix: Include other Conventional Commit types#192nMoncho wants to merge 1 commit intotomasbjerre:masterfrom
Conversation
|
|
||
| {{#commits}} | ||
| {{#ifCommitType . type='^$'}} | ||
| {{#ifCommitType . type='^($^|(?!fix|feat|breaking|chore).*)'}} |
There was a problem hiding this comment.
#ifCommitType . type='^$' expects the commit type to be empty. By using the same expression as line 50, we can include both empty types, and other types such as refactor:, docs:, etc.
There was a problem hiding this comment.
I would encourage all users to create their own custom template and adjust it exactly as they want. All tools using this library should offer that feature.
nMoncho
force-pushed
the
fix/other-changes
branch
from
ee6c98a to
bc1d6e7
Compare
|
|
||
| [{{subString hash 0 5}}](https://github.com/{{ownerName}}/{{repoName}}/commit/{{hash}}) {{authorName}} *{{commitTime}}* | ||
|
|
||
| {{/ifCommitTypeOtherThan}} |
There was a problem hiding this comment.
We also need to make sure the chores that aren't dependency updates are included in the list, as the chore(deps) were included in Dependency updates section
There was a problem hiding this comment.
This probably means you should have your own complete template. I personally dont want the chores in the changelog.
|
Fair enough, thank you for checking this so quickly. I'll close the PR. |
2 participants
As mentioned on https://www.conventionalcommits.org/en/v1.0.0/ other commit types are allowed. For example
build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.Currently the
changelog.mustachetemplate would drop commits that aren'tfix|feat|breaking|chore, and we would probably like to see them in theOther Changessection.