rustup 2015-01-02 #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
forgot to mention... I also moved the IntoString trait here, as it's now deprecated by rust-lang/rust#20306 but I think Ascii will still need a way to convert a Vec to a String. If you prefer to keep the deprecated one, I can remove it from here and add a |
Collaborator
|
@tomprogrammer, do you want to take care of this? |
Owner
|
@pfalabella I prefer to provide IntoString in ascii as you did because deprecated traits can be removed from std without warning. Good work! @SimonSapin I will take care and publish a new version. |
tomprogrammer
added a commit
that referenced
this pull request
Jan 4, 2015
Follow rust/std changes - Rename deriving to derive - Provide IntoString in this crate instead of std - See nikomatsakis/rust@c61a009 for old_orphan_check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new orphan check does not play well with Hash. Disabled temporarily as per nikomatsakis/rust@c61a009.
Also, Sized? is now the default, and OwnedAsciiCast needs to explicitly inherit from Sized