hs-v3: Don't close intro circuit for an encrypted descriptor #1782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To close intro circuits, we need a valid decrypted descriptor in order to find the circuit by authentication key. However, we can have encrypted descriptors in the client cache that are waiting for a client authorization token. This commit doesn't attempt to close intro circuits for that situation because we are unable to access the authentication key for each intro circuit. Signed-off-by: David Goulet <[email protected]>
Pull Request Test Coverage Report for Build 8303
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To close intro circuits, we need a valid decrypted descriptor in order to find
the circuit by authentication key. However, we can have encrypted descriptors
in the client cache that are waiting for a client authorization token.
This commit doesn't attempt to close intro circuits for that situation because
we are unable to access the authentication key for each intro circuit.
Signed-off-by: David Goulet [email protected]