✨ feat(async): add AsyncReadWriteLock#506
Merged
gaborbernat merged 1 commit intotox-dev:mainfrom Mar 1, 2026
Merged
Conversation
Issue tox-dev#505 requests async read/write lock support. Since Python's sqlite3 module has no async API, AsyncReadWriteLock wraps the existing ReadWriteLock and dispatches all blocking SQLite operations to a thread pool via loop.run_in_executor — the same pattern used by BaseAsyncFileLock. Closes tox-dev#505
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library has
AsyncFileLockfor async file locking andReadWriteLockfor sync shared-read/exclusive-write locking, but no way to use read/write locks from async code. This was requested in #505.Since Python's
sqlite3module has no async API,AsyncReadWriteLockwraps the existingReadWriteLockand dispatches all blocking SQLite operations to a thread pool vialoop.run_in_executor()— the same pattern already used byBaseAsyncFileLock. 🔄 The class uses composition rather than inheritance becauseReadWriteLockhas a fundamentally different hierarchy fromBaseFileLock. All reentrancy, upgrade/downgrade, and singleton semantics are delegated to the innerReadWriteLockinstance.The async context managers
read_lock()andwrite_lock()mirror the sync API, and a custom executor can be passed for applications that need control over the thread pool. ✨ The SphinxPatchedPythonDomainwas extended to map internal stdlib paths (asyncio.events.AbstractEventLoop,concurrent.futures._base.Executor) to their public equivalents, which benefits any future code using these types in documented signatures.Closes #505