Draft
Conversation
idesai
force-pushed
the
add_pcrauth_status
branch
from
35c0cc7 to
279b4ba
Compare
Member
Author
|
TODO:
|
idesai
force-pushed
the
add_pcrauth_status
branch
3 times, most recently
from
377c8db to
313e8f7
Compare
… set Signed-off-by: Imran Desai <imran.desai@intel.com>
Fixes tpm2-software#3333 Signed-off-by: Imran Desai <imran.desai@intel.com>
idesai
force-pushed
the
add_pcrauth_status
branch
from
313e8f7 to
0ae8cee
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3337 +/- ##
==========================================
- Coverage 74.38% 73.97% -0.42%
==========================================
Files 173 174 +1
Lines 23673 23835 +162
==========================================
+ Hits 17610 17631 +21
- Misses 6063 6204 +141 ☔ View full report in Codecov by Sentry. |
Member
|
Hmmmmm... you know that pcrsetauthvalue is forbidden for all PTP compatible TPMs, right ? |
Member
Author
This is implementing the command spec for TPMs that implement the command. |
Member
|
Please add big warnings to the manpage and also to the error printf's that this is not included in PC-Client compatible TPM; indicating that this is actually forbidden for PTP compliant TPMs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3330
Fixes #3333