ld64: Swap LTO_RPATH to LTO_LIB - Fixes LTO on macOS#121
Open
Gcenx wants to merge 1 commit intotpoechtrager:masterfrom
Open
ld64: Swap LTO_RPATH to LTO_LIB - Fixes LTO on macOS#121Gcenx wants to merge 1 commit intotpoechtrager:masterfrom
Gcenx wants to merge 1 commit intotpoechtrager:masterfrom
Conversation
Fixes LTO linking on macOS this follows what's done with other libraries in ld_LDADD section
Owner
|
ld64 shouldn't link against libLTO. The library is loaded dynamically. If linking against it is indeed needed on macOS, then feel free to adjust the PR so it affects only macOS. |
Author
|
I’ll look over this again, I can’t remember if the rpath was configured correctly or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes LTO linking on macOS this follows what's done with other libraries in ld_LDADD section
Closes #120