Avoid dead-stripping rust compiler_builtins atoms#135
Open
glandium wants to merge 1 commit into
Open
Conversation
glandium
commented
Jul 5, 2023
| // Likewise with rust compiler_builtins atoms. They may come from a libcompiler_builtins-<hash>.a lib, or from a compiler_builtins-... member of a rust static library. | ||
| else if ( _haveLLVMObjs && !force && (atom->contentType() != ld::Atom::typeLTOtemporary) ) { | ||
| if ( isCompilerSupportLib(atom->safeFilePath()) ) { | ||
| if ( isCompilerSupportLib(atom->safeFilePath()) || strstr(atom->safeFilePath(), "compiler_builtins") != nullptr ) ) { |
Contributor
Author
There was a problem hiding this comment.
Note that I didn't add this check in isCompilerSupportLib because I wasn't sure of the side effects from other code using that function.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 11, 2023
…ns atoms. r=firefox-build-system-reviewers,ahochheiden Sent upstream at tpoechtrager/cctools-port#135. Differential Revision: https://phabricator.services.mozilla.com/D182833
vinnydiehl
pushed a commit
to vinnydiehl/mozilla-unified
that referenced
this pull request
Jul 12, 2023
…ns atoms. r=firefox-build-system-reviewers,ahochheiden Sent upstream at tpoechtrager/cctools-port#135. Differential Revision: https://phabricator.services.mozilla.com/D182833
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jul 16, 2023
…ns atoms. r=firefox-build-system-reviewers,ahochheiden Sent upstream at tpoechtrager/cctools-port#135. Differential Revision: https://phabricator.services.mozilla.com/D182833 UltraBlame original commit: 03b2eccaf86fbc9cb989ec3d9dfce6e12e827a7e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jul 16, 2023
…ns atoms. r=firefox-build-system-reviewers,ahochheiden Sent upstream at tpoechtrager/cctools-port#135. Differential Revision: https://phabricator.services.mozilla.com/D182833 UltraBlame original commit: 03b2eccaf86fbc9cb989ec3d9dfce6e12e827a7e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jul 16, 2023
…ns atoms. r=firefox-build-system-reviewers,ahochheiden Sent upstream at tpoechtrager/cctools-port#135. Differential Revision: https://phabricator.services.mozilla.com/D182833 UltraBlame original commit: 03b2eccaf86fbc9cb989ec3d9dfce6e12e827a7e
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
…ns atoms. r=firefox-build-system-reviewers,ahochheiden Sent upstream at tpoechtrager/cctools-port#135. Differential Revision: https://phabricator.services.mozilla.com/D182833
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.