Cleanup crypto code in shim.js #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up the crypto stuff in shim.js. Getting rid of the sha256 algo hack, since it no longer seems necessary with browserify-sign 4.0.0 and later. Requiring a newer version of react-native-crypto, which populates window.getRandomValues() function for us (and has a bug fix to that function for non-Uint8 Typed Arrays). Also adding a reminder in README to link libraries.
Note: This has to be merged after the react-native-crypto PR is merged, otherwise react-native-crypto 2.1.0 won't exist.