Skip to content

feat: Enable workflow control operations by default#72

Merged
xerial merged 1 commit intomainfrom
enable-workflow-control-operations
Jun 30, 2025
Merged

feat: Enable workflow control operations by default#72
xerial merged 1 commit intomainfrom
enable-workflow-control-operations

Conversation

@xerial
Copy link
Member

@xerial xerial commented Jun 30, 2025

Summary

Enable kill_attempt, retry_session, and retry_attempt operations by default without requiring TD_ENABLE_UPDATES.

Changes

Removed TD_ENABLE_UPDATES requirement from:

  • kill_attempt - Sends a cancellation request to a running attempt
  • retry_session - Creates a new attempt for a session
  • retry_attempt - Creates a new attempt with resume capabilities

Rationale

These operations are safe and don't directly modify or delete data:

  • Retry operations create new attempts rather than modifying existing ones
  • Kill operation sends a cancellation request, doesn't forcefully terminate
  • The workflow API itself handles validation and ensures operations are safe

Updated

  • Removed enable_updates checks from the three workflow control tools
  • Updated tests to reflect that these operations work without TD_ENABLE_UPDATES
  • Updated design documentation to clarify security considerations

Testing

  • All existing tests pass
  • Updated tests verify that operations work regardless of enable_updates setting
  • Integration tests confirm the operations are available by default

🤖 Generated with Claude Code

- Remove TD_ENABLE_UPDATES restriction from kill_attempt, retry_session, and retry_attempt
- These operations are safe as they don't directly modify data:
  - retry_session and retry_attempt create new attempts rather than modifying existing ones
  - kill_attempt sends a cancellation request, doesn't forcefully terminate
- Update tests to reflect that these operations no longer require TD_ENABLE_UPDATES
- Update documentation to clarify the security considerations

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@xerial xerial merged commit bf6381f into main Jun 30, 2025
7 checks passed
@xerial xerial deleted the enable-workflow-control-operations branch June 30, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant