extract PB helper macros into separate file #6198
Open
+63
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| model | device_test | click_test | persistence_test |
|---|---|---|---|
| T2T1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
| T3B1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
| T3T1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
| T3W1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
Latest CI run: 19852009639
kopecdav
requested changes
Dec 8, 2025
| } | ||
| #define MSG_SEND_ASSIGN_STRING(FIELD, VALUE) \ | ||
| { \ | ||
| msg_send.has_##FIELD = true; \ |
Contributor
There was a problem hiding this comment.
Nitpick:
In the header file, macros are using the functions/structures which are not included in the same file
Not sure how much is it an issue, just feel bit strange to use the macro somewhere and need to be sure that the correct functions/structure declarations are already available.
github-project-automation
bot
moved this from 🔎 Needs review
to 🏃♀️ In progress
in Firmware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor bootloader refactoring as preparation for introducing bootloader tests