Skip to content

Comments

🐛 fix(ci): Add binary verification step after npm ci for all platforms#147

Merged
trickpatty merged 1 commit intomainfrom
claude/fix-electron-ci-binary-extraction-I7DQZ
Jan 19, 2026
Merged

🐛 fix(ci): Add binary verification step after npm ci for all platforms#147
trickpatty merged 1 commit intomainfrom
claude/fix-electron-ci-binary-extraction-I7DQZ

Conversation

@trickpatty
Copy link
Owner

GitHub Actions npm cache can serve stale cached node_modules that don't include properly extracted binaries from app-builder-bin. This causes electron-builder to fail with ENOENT errors when it can't find the app-builder binary.

This fix adds a verification step after npm ci for all four platforms:

  • Linux: checks linux/x64/app-builder
  • Windows: checks win/x64/app-builder.exe
  • macOS Intel: checks mac/app-builder
  • macOS ARM: checks mac/app-builder

If the binary is missing, the step reinstalls app-builder-bin with --force to ensure proper extraction, then sets execute permissions.

Root cause: The move to npm workspaces (d5ef0c0) combined with the change to workspace-level npm install (91f3a11) caused GitHub Actions cache to serve incomplete cached dependencies without the binary files.

GitHub Actions npm cache can serve stale cached node_modules that don't
include properly extracted binaries from app-builder-bin. This causes
electron-builder to fail with ENOENT errors when it can't find the
app-builder binary.

This fix adds a verification step after npm ci for all four platforms:
- Linux: checks linux/x64/app-builder
- Windows: checks win/x64/app-builder.exe
- macOS Intel: checks mac/app-builder
- macOS ARM: checks mac/app-builder

If the binary is missing, the step reinstalls app-builder-bin with --force
to ensure proper extraction, then sets execute permissions.

Root cause: The move to npm workspaces (d5ef0c0) combined with the change
to workspace-level npm install (91f3a11) caused GitHub Actions cache to
serve incomplete cached dependencies without the binary files.
@trickpatty trickpatty merged commit 3eff706 into main Jan 19, 2026
12 checks passed
@trickpatty trickpatty deleted the claude/fix-electron-ci-binary-extraction-I7DQZ branch January 19, 2026 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants