🐛 fix(ci): Install dependencies directly in display directory to bypass workspace hoisting#155
Merged
trickpatty merged 1 commit intomainfrom Jan 25, 2026
Merged
Conversation
…ss workspace hoisting The previous approach (global electron-builder install) has known permission issues on GitHub Actions runners after version 20240403.1.0 (EACCES errors). This fix uses the recommended approach: install dependencies directly in the display directory with --workspaces=false flag, which: - Bypasses npm workspace hoisting completely - Creates clients/display/node_modules/ with all dependencies - Ensures electron-builder can find app-builder-bin via normal module resolution - Follows best practices (npx electron-builder, not global install) Changes for all platforms (Linux, Windows, macOS Intel, macOS ARM): - Install deps in ./clients/display with --workspaces=false --legacy-peer-deps - Verify platform-specific app-builder-bin binary exists - Use npx electron-builder instead of global command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous approach (global electron-builder install) has known permission issues on GitHub Actions runners after version 20240403.1.0 (EACCES errors).
This fix uses the recommended approach: install dependencies directly in the display directory with --workspaces=false flag, which:
Changes for all platforms (Linux, Windows, macOS Intel, macOS ARM):