Add support for MAP type to SQLAlchemy dialect#448
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
bcbbd4e to
42bf347
Compare
|
For what it's worth this may not be complete juding by the JSON impl at ab0e596 and the STRUCT impl in BigQuery at https://github.com/googleapis/python-bigquery-sqlalchemy/blob/main/sqlalchemy_bigquery/_struct.py Not all operations may work on the type and are out of scope for this pull-request. I had planned to add support for all structural types (ARRAY, MAP and ROW) but I'll leave that to folks who have strong motivation to work with the complex SQLAlchemy API. 😩 |
42bf347 to
1ca2a69
Compare
Co-authored-by: dudu butbul <100126964+dudu-upstream@users.noreply.github.com> Co-authored-by: Ashhar Hasan <ashhar.hasan@starburstdata.com>
1ca2a69 to
59c9585
Compare
Description
Adds support for MAP type to SQLA dialect.
Fixes #397
Supersedes #398
This preserves commit authorship from #398.
Release notes
(x) Release notes are required, with the following suggested text: