Refactor get_indexes to return partition names and values#486
Merged
hashhar merged 1 commit intotrinodb:masterfrom Sep 26, 2024
Merged
Refactor get_indexes to return partition names and values#486hashhar merged 1 commit intotrinodb:masterfrom
hashhar merged 1 commit intotrinodb:masterfrom
Conversation
hashhar
requested changes
Sep 26, 2024
c5b3711 to
4d90a35
Compare
hashhar
approved these changes
Sep 26, 2024
hovaesco
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #476
get_indexesrefactored to return list of dicts with partition name and partition values.example output:
[ { 'partition_name': 'part_a', 'partition_values': ['val1', 'val2', 'val3'] }, { 'partition_name': 'part_b', 'partition_values': ['val4', 'val5', 'val6'] } ]Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: