add SESSION_AUTHORIZATION to client capabilities#551
Merged
wendigo merged 2 commits intotrinodb:masterfrom May 2, 2025
Merged
Conversation
hashhar
reviewed
Apr 15, 2025
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
Thanks, I'll make some changes and merge - namely adding constants for the capabilities header value since it ideally should be exactly the same everywhere in the client.
Contributor
Author
|
Would be happy to do that @hashhar. Where do you think would be the best place to add that in? And are we okay with adding it to this PR? |
wendigo
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR seeks to resolve issue #545.
Trino expects the Client Capabilities header
SESSION_AUTHORIZATIONexists so that it allows theSET SESSION AUTHORIZATION.This wasn't added in the initial PR
Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
(x) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: