Merged
Conversation
dain
commented
Jul 2, 2022
Member
Author
There was a problem hiding this comment.
This is the actual fix. The writer thread may be different from the reader thread, and without the synchronization, you can get an old view of the list.
testing/trino-tests/src/test/java/io/trino/execution/EventsCollector.java
Outdated
Show resolved
Hide resolved
Member
Author
There was a problem hiding this comment.
Also this is not testing for split completed, so explicitly ignore them incase we somehow ended up with an extra split, which is very unlikely given this is a VALUES query
losipiuk
approved these changes
Jul 3, 2022
phd3
reviewed
Jul 3, 2022
Member
phd3
left a comment
phd3
left a comment
There was a problem hiding this comment.
lgtm.
nit: may be change the last commit msg to Add more debug information
testing/trino-tests/src/test/java/io/trino/execution/TestConnectorEventListener.java
Outdated
Show resolved
Hide resolved
testing/trino-tests/src/test/java/io/trino/execution/EventsCollector.java
Outdated
Show resolved
Hide resolved
Test should explicitly ignore split events which it is not testing
dain
force-pushed
the
fix-event-collector
branch
from
9dd6ffa to
28363d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix basic thread safety issues in EventsCollector.
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: