Merged
Conversation
Jessie212
force-pushed
the
jt/launcher-commands
branch
from
ffeb4ed to
0d5c5e2
Compare
martint
reviewed
Jul 8, 2022
Jessie212
force-pushed
the
jt/launcher-commands
branch
from
0d5c5e2 to
adef5c5
Compare
Jessie212
force-pushed
the
jt/launcher-commands
branch
from
adef5c5 to
69857ad
Compare
mosabua
reviewed
Jul 14, 2022
mosabua
reviewed
Jul 14, 2022
Jessie212
force-pushed
the
jt/launcher-commands
branch
from
69857ad to
5ec80bb
Compare
mosabua
reviewed
Jul 14, 2022
mosabua
reviewed
Jul 14, 2022
mosabua
reviewed
Jul 14, 2022
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
Clarified some more stuff in the comments.
mosabua
reviewed
Jul 14, 2022
Member
There was a problem hiding this comment.
Some of the stuff later down should be cleaned up as well .. ping me if you want to fine tune together @Jessie212
Ordinant
approved these changes
Jul 14, 2022
Member
Ordinant
left a comment
Ordinant
left a comment
There was a problem hiding this comment.
Looks fine to me, but I didn't check line wrapping issues.
Jessie212
force-pushed
the
jt/launcher-commands
branch
from
5ec80bb to
e9d024a
Compare
Jessie212
force-pushed
the
jt/launcher-commands
branch
from
e9d024a to
7db77d4
Compare
Member
|
This is ready now @martint .. for merge right after the release is done ;-) |
Contributor
Author
|
@martint Can you merge this PR, please? The build failure is a false alarm. |
Member
|
Build failure is wrong. I just built locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improvement.
Changes were made to documentation only.
Add launch command section to Trino deployment page.
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: